feat: add tests for actor lifecycle #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-platform
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
fnesveda
requested changes
Jan 25, 2023
There was a problem hiding this comment.
Looks good! I had just a few suggestions.
Maybe you could also check that the event emitting intervals for ActorEventType.PERSIST_STATE and ActorEventType.SYSTEM_INFO work correctly, and that they're stopped after Actor.exit().
Hint - you can speed them up by setting lower APIFY_PERSIST_STATE_INTERVAL_MILLIS env var, and lower Actor.config.system_info_interval_millis config.
Maybe we could make the Actor.config.system_info_interval_millis also be read from an env var, it would make it a bit more consistent.
jirimoravcik
approved these changes
Jan 25, 2023
Co-authored-by: Jiří Moravčík <[email protected]>
fnesveda
approved these changes
Jan 26, 2023
Comment on lines
+129
to
+130
| # NOTE: Actor didn't call sys.exit() during testing, check if fail was called. | ||
| my_actor.fail.assert_called_with(exit_code=91, _exc_type=type(err), _exc_value=err, _exc_traceback=err.__traceback__) |
fnesveda
added
the
validated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests look quite dummy from the second look, if you have any idea what should we test let me know in PR.