Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new config variables to Actor.config #351

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

fnesveda
Copy link
Member

@fnesveda fnesveda commented Dec 6, 2024

We have added a few new environment variables:

  • ACTOR_BUILD_TAGS
  • ACTOR_FULL_NAME
  • ACTOR_MAX_TOTAL_CHARGE_USD

This adds corresponding config variables to Actor.config. ACTOR_BUILD_TAGS is a comma-separated list of build tags, so I've added a mechanism to parse the string environment variable into a list.

@fnesveda fnesveda added t-platform Issues with this label are in the ownership of the platform team. adhoc Ad-hoc unplanned task added during the sprint. labels Dec 6, 2024
@fnesveda fnesveda added this to the 104th sprint - Platform team milestone Dec 6, 2024
@fnesveda fnesveda requested review from janbuchar and vdusek December 6, 2024 12:18
@fnesveda fnesveda self-assigned this Dec 6, 2024
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Dec 6, 2024
@fnesveda
Copy link
Member Author

fnesveda commented Dec 6, 2024

The unit tests for Python 3.13 are failing, but it's not related to this change, they seem to be failing on other PRs too.

Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek
Copy link
Contributor

vdusek commented Dec 9, 2024

The unit tests for Python 3.13 are failing, but it's not related to this change, they seem to be failing on other PRs too.

Yeah, we're aware of that, and we will skip it for 3.13.

@fnesveda fnesveda merged commit 7b6478c into master Dec 11, 2024
29 checks passed
@fnesveda fnesveda deleted the feat/new-env-vars branch December 11, 2024 10:10
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-platform Issues with this label are in the ownership of the platform team. tested Temporary label used only programatically for some analytics. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants