Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add docs for Dataset, KeyValueStore, and RequestQueue #37

Merged
merged 4 commits into from
Jan 30, 2023
Merged

feat: Add docs for Dataset, KeyValueStore, and RequestQueue #37

merged 4 commits into from
Jan 30, 2023

Conversation

jirimoravcik
Copy link
Member

No description provided.

@github-actions github-actions bot added this to the 55th sprint - Platform team milestone Jan 26, 2023
@github-actions github-actions bot added the t-platform Issues with this label are in the ownership of the platform team. label Jan 26, 2023
fnesveda
fnesveda requested changes Jan 27, 2023
View reviewed changes
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small point about the recommendations to use the XXX.open() method

src/apify/storages/dataset.py Outdated Show resolved Hide resolved
src/apify/storages/key_value_store.py Outdated Show resolved Hide resolved
src/apify/storages/request_queue.py Outdated Show resolved Hide resolved
@jirimoravcik jirimoravcik requested a review from fnesveda January 27, 2023 15:55
@jirimoravcik jirimoravcik changed the title feat: Add documentation for Dataset, KeyValueStore, and RequestQueue feat: Add docs for Dataset, KeyValueStore, and RequestQueue Jan 29, 2023
@jirimoravcik jirimoravcik merged commit 174548e into master Jan 30, 2023
@jirimoravcik jirimoravcik deleted the feature/docs-for-storages branch January 30, 2023 12:42
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drobnikj drobnikj drobnikj approved these changes

@fnesveda fnesveda fnesveda approved these changes

Assignees

@jirimoravcik jirimoravcik

Labels
t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Milestone
56th sprint - Platform team
Development

Successfully merging this pull request may close these issues.
3 participants
@jirimoravcik @fnesveda @drobnikj