Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test for storage actor methods #39

Merged
merged 6 commits into from
Jan 31, 2023

Conversation

drobnikj
Copy link
Member

No description provided.

Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

tests/unit/actor/test_actor_key_value_store.py Outdated Show resolved Hide resolved
@drobnikj drobnikj requested a review from jirimoravcik January 30, 2023 12:43
@github-actions github-actions bot added this to the 56th sprint - Platform team milestone Jan 30, 2023
@github-actions github-actions bot added the t-platform Issues with this label are in the ownership of the platform team. label Jan 30, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@drobnikj drobnikj requested a review from jirimoravcik January 31, 2023 11:02
memory_storage: MemoryStorage,
) -> None:
default_dataset_name = 'my-new-default-name'
await memory_storage.datasets().get_or_create(name=default_dataset_name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line even needed?

@drobnikj drobnikj merged commit b89bbcf into master Jan 31, 2023
@drobnikj drobnikj deleted the feat/actor_storage_method_tests branch January 31, 2023 13:17
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants