Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a few integration tests #48

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

drobnikj
Copy link
Member

@drobnikj drobnikj commented Feb 2, 2023

No description provided.

@github-actions github-actions bot added this to the 56th sprint - Platform team milestone Feb 2, 2023
@github-actions github-actions bot added the t-platform Issues with this label are in the ownership of the platform team. label Feb 2, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@drobnikj drobnikj marked this pull request as ready for review February 2, 2023 17:13

class TestActorNewClient:

async def test_actor_new_client_config(self, monkeypatch: pytest.MonkeyPatch) -> None:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test is in helpers, not sure why it was there as well.

Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just had two small suggestions but they're not too important.

tests/integration/test_actor_events.py Outdated Show resolved Hide resolved
tests/integration/test_actor_lifecycle.py Outdated Show resolved Hide resolved
@drobnikj drobnikj merged commit 1843f48 into master Feb 8, 2023
@drobnikj drobnikj deleted the feat/lifecycle_methods_integration_tests branch February 8, 2023 08:58
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 9, 2023
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-platform Issues with this label are in the ownership of the platform team. tested Temporary label used only programatically for some analytics. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants