-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RequestQueue v2 locking #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests please
Just checked the tests, and they seem fine to me :) Some tiny nits:
|
Same here, I was also a bit confused by that, but saw that it was done this way before... I'd argue we don't even need to go through the prepared statements for every single query, it makes sense only for those that will be repeated very often. Either way, this deserves some abstraction so we don't need to handle it again and again for every single query. |
Good point, will change |
No description provided.