fix: save context state in result for AdaptivePlaywrightCrawler after isolated processing in SubCrawler
#1488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mantisus
changed the title
AdaptivePlaywrightCrawler after isolated processing in SubCrawlerAdaptivePlaywrightCrawler after isolated processing in SubCrawler
|
Please add the test that will cover the reported issue. |
Added |
Pijukatel
approved these changes
Oct 17, 2025
janbuchar
reviewed
Oct 22, 2025
tests/unit/crawlers/_adaptive_playwright/test_adaptive_playwright_crawler.py
Outdated
Show resolved
Hide resolved
tests/unit/crawlers/_adaptive_playwright/test_adaptive_playwright_crawler.py
Outdated
Show resolved
Hide resolved
src/crawlee/crawlers/_adaptive_playwright/_adaptive_playwright_crawler.py
Outdated
Show resolved
Hide resolved
src/crawlee/crawlers/_adaptive_playwright/_adaptive_playwright_crawler.py
Outdated
Show resolved
Hide resolved
janbuchar
approved these changes
Oct 24, 2025
| context.log.debug(f'Detected rendering type {detection_result} for {context.request.url}') | ||
| self.rendering_type_predictor.store_result(context.request, detection_result) | ||
|
|
||
| self._update_context_from_copy(context, pw_run.run_context) |
There was a problem hiding this comment.
I think that we should make the changes made to the context part of the RequestHandlerResult data structure at some point. What do you think @Mantisus @Pijukatel?
No need to stall this PR because of that, it can be done later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AdaptivePlaywrightCrawlerafter isolated processing inSubCrawlerIssues