Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use strip in headers normalization #614

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: use strip in headers normalization #614

merged 1 commit into from
Oct 23, 2024
+99 −98

Conversation

vdusek
Copy link
Collaborator

@vdusek vdusek commented Oct 23, 2024 •
edited
Loading

Description

  • Use strip in headers normalization.
  • Remove redundant "defaults to" in docstrings.
  • Improve compute_unique_key tests.

Issues

  • N/A

Testing

  • The "fix" is covered by tests now.

Checklist

  • CI passed

@vdusek vdusek added bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Oct 23, 2024
@vdusek vdusek added this to the 101st sprint - Tooling team milestone Oct 23, 2024
@vdusek vdusek requested a review from janbuchar October 23, 2024 13:00
@vdusek vdusek self-assigned this Oct 23, 2024
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Oct 23, 2024
janbuchar
janbuchar approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek merged commit a15b21e into master Oct 23, 2024
20 checks passed
@vdusek vdusek deleted the strip-in-normalize-headers branch October 23, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbuchar janbuchar janbuchar approved these changes

Assignees

@vdusek vdusek

Labels
adhoc Ad-hoc unplanned task added during the sprint. bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
101st sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@vdusek @janbuchar