feat: If custom logger is set, pass to the AutoScaledPool #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aayusharyan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Even if I use a custom logger object to set the logs in my Crawlee instance, for the AutoScaled logs, it still uses the default logger. Ideally, when I am passing it to Crawlee, then it should also be internally shared across other subclasses.
Changed the AutoScaledPool constructor to also accept logger instance, if not sent, then create a new logger.
Issues
Can be loosely said to improve logging for (#157)
Testing
Need a little help/time to figure out why
test_emit_system_info_eventis breaking.Checklist