Proposing update for parsing Float (#131)

* Update custom-formats.js * Edit test files to reflect changes in new parsing custom float format with Number.parseFloat(val)
apigee-127 · Apr 25, 2017 · 6bf388e · 6bf388e
1 parent 8f58f80
commit 6bf388e
Show file tree

Hide file tree

Showing 13 changed files with 78 additions and 26 deletions.
diff --git a/custom-formats.js b/custom-formats.js
@@ -21,8 +21,12 @@ module.exports = function(zSchema) {
   });
 
   zSchema.registerFormat('float', function(val) {
-    // should parse
-    return Number.isInteger(val);
+    // better parsing for custom "float" format
+    if (Number.parseFloat(val)) {
+      return true;
+    } else {
+      return false;
+    }
   });
 
   zSchema.registerFormat('date', function(val) {

diff --git a/test/loadTest/compare/request/assert/base-path-test.js b/test/loadTest/compare/request/assert/base-path-test.js
@@ -24,8 +24,12 @@ var customFormats = module.exports = function(zSchema) {
   });
 
   zSchema.registerFormat('float', function(val) {
-    // should parse
-    return Number.isInteger(val);
+    // better parsing for custom "float" format
+    if (Number.parseFloat(val)) {
+      return true;
+    } else {
+      return false;
+    }
   });
 
   zSchema.registerFormat('date', function(val) {

diff --git a/test/loadTest/compare/request/expect/base-path-test.js b/test/loadTest/compare/request/expect/base-path-test.js
@@ -24,8 +24,12 @@ var customFormats = module.exports = function(zSchema) {
   });
 
   zSchema.registerFormat('float', function(val) {
-    // should parse
-    return Number.isInteger(val);
+    // better parsing for custom "float" format
+    if (Number.parseFloat(val)) {
+      return true;
+    } else {
+      return false;
+    }
   });
 
   zSchema.registerFormat('date', function(val) {

diff --git a/test/loadTest/compare/request/should/base-path-test.js b/test/loadTest/compare/request/should/base-path-test.js
@@ -24,8 +24,12 @@ var customFormats = module.exports = function(zSchema) {
   });
 
   zSchema.registerFormat('float', function(val) {
-    // should parse
-    return Number.isInteger(val);
+    // better parsing for custom "float" format
+    if (Number.parseFloat(val)) {
+      return true;
+    } else {
+      return false;
+    }
   });
 
   zSchema.registerFormat('date', function(val) {

diff --git a/test/loadTest/compare/supertest/assert/base-path-test.js b/test/loadTest/compare/supertest/assert/base-path-test.js
@@ -24,8 +24,12 @@ var customFormats = module.exports = function(zSchema) {
   });
 
   zSchema.registerFormat('float', function(val) {
-    // should parse
-    return Number.isInteger(val);
+    // better parsing for custom "float" format
+    if (Number.parseFloat(val)) {
+      return true;
+    } else {
+      return false;
+    }
   });
 
   zSchema.registerFormat('date', function(val) {

diff --git a/test/loadTest/compare/supertest/expect/base-path-test.js b/test/loadTest/compare/supertest/expect/base-path-test.js
@@ -24,8 +24,12 @@ var customFormats = module.exports = function(zSchema) {
   });
 
   zSchema.registerFormat('float', function(val) {
-    // should parse
-    return Number.isInteger(val);
+    // better parsing for custom "float" format
+    if (Number.parseFloat(val)) {
+      return true;
+    } else {
+      return false;
+    }
   });
 
   zSchema.registerFormat('date', function(val) {

diff --git a/test/loadTest/compare/supertest/should/base-path-test.js b/test/loadTest/compare/supertest/should/base-path-test.js
@@ -24,8 +24,12 @@ var customFormats = module.exports = function(zSchema) {
   });
 
   zSchema.registerFormat('float', function(val) {
-    // should parse
-    return Number.isInteger(val);
+    // better parsing for custom "float" format
+    if (Number.parseFloat(val)) {
+      return true;
+    } else {
+      return false;
+    }
   });
 
   zSchema.registerFormat('date', function(val) {

diff --git a/test/robust/compare/request/assert/base-path-test.js b/test/robust/compare/request/assert/base-path-test.js
@@ -24,8 +24,12 @@ var customFormats = module.exports = function(zSchema) {
   });
 
   zSchema.registerFormat('float', function(val) {
-    // should parse
-    return Number.isInteger(val);
+    // better parsing for custom "float" format
+    if (Number.parseFloat(val)) {
+      return true;
+    } else {
+      return false;
+    }
   });
 
   zSchema.registerFormat('date', function(val) {

diff --git a/test/robust/compare/request/expect/base-path-test.js b/test/robust/compare/request/expect/base-path-test.js
@@ -24,8 +24,12 @@ var customFormats = module.exports = function(zSchema) {
   });
 
   zSchema.registerFormat('float', function(val) {
-    // should parse
-    return Number.isInteger(val);
+    // better parsing for custom "float" format
+    if (Number.parseFloat(val)) {
+      return true;
+    } else {
+      return false;
+    }
   });
 
   zSchema.registerFormat('date', function(val) {

diff --git a/test/robust/compare/request/should/base-path-test.js b/test/robust/compare/request/should/base-path-test.js
@@ -24,8 +24,12 @@ var customFormats = module.exports = function(zSchema) {
   });
 
   zSchema.registerFormat('float', function(val) {
-    // should parse
-    return Number.isInteger(val);
+    // better parsing for custom "float" format
+    if (Number.parseFloat(val)) {
+      return true;
+    } else {
+      return false;
+    }
   });
 
   zSchema.registerFormat('date', function(val) {

diff --git a/test/robust/compare/supertest/assert/base-path-test.js b/test/robust/compare/supertest/assert/base-path-test.js
@@ -24,8 +24,12 @@ var customFormats = module.exports = function(zSchema) {
   });
 
   zSchema.registerFormat('float', function(val) {
-    // should parse
-    return Number.isInteger(val);
+    // better parsing for custom "float" format
+    if (Number.parseFloat(val)) {
+      return true;
+    } else {
+      return false;
+    }
   });
 
   zSchema.registerFormat('date', function(val) {

diff --git a/test/robust/compare/supertest/expect/base-path-test.js b/test/robust/compare/supertest/expect/base-path-test.js
@@ -24,8 +24,12 @@ var customFormats = module.exports = function(zSchema) {
   });
 
   zSchema.registerFormat('float', function(val) {
-    // should parse
-    return Number.isInteger(val);
+    // better parsing for custom "float" format
+    if (Number.parseFloat(val)) {
+      return true;
+    } else {
+      return false;
+    }
   });
 
   zSchema.registerFormat('date', function(val) {

diff --git a/test/robust/compare/supertest/should/base-path-test.js b/test/robust/compare/supertest/should/base-path-test.js
@@ -24,8 +24,12 @@ var customFormats = module.exports = function(zSchema) {
   });
 
   zSchema.registerFormat('float', function(val) {
-    // should parse
-    return Number.isInteger(val);
+    // better parsing for custom "float" format
+    if (Number.parseFloat(val)) {
+      return true;
+    } else {
+      return false;
+    }
   });
 
   zSchema.registerFormat('date', function(val) {