Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper entity query support #794

Draft
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

mxr576
Copy link
Contributor

@mxr576 mxr576 commented Feb 1, 2023

This is a follow up on #790 which aim was hot fixing only. The scope of this PR is finalizing the task by adding similar level of entity query support as content entity types have in Drupal core.

Remaining tasks:

  • Test coverage that ensures entity query related hooks are called
  • Bump Entity module version requirement after this issue is fixed and released in a new stable

PS.:

@mxr576 mxr576 force-pushed the entity_query_support branch from 0697d17 to cb4b363 Compare February 2, 2023 07:19
@mxr576 mxr576 force-pushed the entity_query_support branch from 074daad to 7895d96 Compare February 2, 2023 08:10
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #794 (4f902ba) into 2.x (1d4ac2a) will not change coverage.
The diff coverage is 93.18%.

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x     #794   +/-   ##
=========================================
  Coverage     43.91%   43.91%           
  Complexity     3021     3021           
=========================================
  Files           342      342           
  Lines         11114    11114           
=========================================
  Hits           4881     4881           
  Misses         6233     6233           
Impacted Files Coverage Δ
src/Entity/Query/Query.php 95.71% <93.18%> (ø)

@mxr576
Copy link
Contributor Author

mxr576 commented Mar 20, 2023

If somebody could RTBC this on Drupal.org, that might speed up the merge of this fix

https://www.drupal.org/project/entity/issues/3332956

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@giteshk
Copy link
Member

giteshk commented May 22, 2023

@mxr576 , @shishir-intelli will validate and respond on drupal.org ticket.

@shishir-intelli
Copy link
Collaborator

If somebody could RTBC this on Drupal.org, that might speed up the merge of this fix

https://www.drupal.org/project/entity/issues/3332956

@mxr576 Done

@mxr576
Copy link
Contributor Author

mxr576 commented Jul 28, 2023

The fix was merged, waiting for a tagged release: https://www.drupal.org/project/entity/issues/3332956

@mxr576
Copy link
Contributor Author

mxr576 commented Oct 3, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants