Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API product access control improvements #250

Open
arlina-espinoza opened this issue Sep 30, 2020 · 4 comments
Open

API product access control improvements #250

arlina-espinoza opened this issue Sep 30, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@arlina-espinoza
Copy link
Collaborator

Follow up for #197. Currently, enabling monetization disables the API product entity access control provided by the apigee_edge_apiproduct_rbac module, showing users only API products for which a developer has accepted a rate plan and API products that are public and do not have a published rate plan (ignoring RBAC).

After discussing with team, we agreed that our approach should be:

  1. If an API product is non monetized, the RBAC module or Apigee Edge simple access control will determine if it is visible.
  2. For monetized API Products, show all API Products which the developer has accepted the rate plan.
@anoopgoel
Copy link

Hi Team,

Hope you are doing well. As part of one of the use case, I need to have role based access to api product and also monetization feature is needed.

I am also facing the same issue as mentioned above and on Issue:197-
"Enabling monetization module disables the API product access control provided by apigee_edge_apiproduct_rbac module".

If I uninstall monetization module then able to assign role based access to api product. But with monetization module, RBAC to api product not working.

Is there any solution for the above issue. If yes, please help me with the same. @arlina-espinoza , @cnovak

Thanks in advance!
Anoop Goel

@kedarkhaire
Copy link
Collaborator

Hi @anoopgoel
While using Monetization, you can only see those products to those you are subscribed. The products cannot be managed with role based access.
For further more details related to Access to Monetization refer this guide.

Thanks!

@anoopgoel
Copy link

Hi @kedarkhaire ,
Thanks for your reply.
However, there are few products which are non-monetized and few products are monetized. Currently both the modules "apigee_edge_apiproduct_rbac and Monetization" are enabled. Having both the modules enabled, I expected it to work in below manner:

  1. Non-Monetized products - Should be controlled via module "apigee_edge_apiproduct_rbac" and non-monetized products should be visible based on the role assigned to the user/group.
  2. Monetized products - Only products, based on the role, should be visible under "Buy APIs".

But above is NOT happening. And once both the modules are installed then all products (monetized and non-monetized) are getting visible to the user (irrespective of the role). If I un-install monetization module then non-monetized products are visible to the user based on their roles.

Please suggest how it can be resolved if need is to use both the modules.

Thanks!

@anoopgoel
Copy link

Hi @kedarkhaire , Thanks for your reply. However, there are few products which are non-monetized and few products are monetized. Currently both the modules "apigee_edge_apiproduct_rbac and Monetization" are enabled. Having both the modules enabled, I expected it to work in below manner:

  1. Non-Monetized products - Should be controlled via module "apigee_edge_apiproduct_rbac" and non-monetized products should be visible based on the role assigned to the user/group.
  2. Monetized products - Only products, based on the role, should be visible under "Buy APIs".

But above is NOT happening. And once both the modules are installed then all products (monetized and non-monetized) are getting visible to the user (irrespective of the role). If I un-install monetization module then non-monetized products are visible to the user based on their roles.

Please suggest how it can be resolved if need is to use both the modules.

Thanks!

Hi Team,

Any suggestions on this please ?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants