Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go (1.20), github actions, and lestrat/jwx #139

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

theganyo
Copy link
Member

@theganyo theganyo commented Jun 14, 2023

includes #138

dependabot bot and others added 3 commits June 14, 2023 17:25
Bumps [github.com/lestrrat-go/jwx](https://github.com/lestrrat-go/jwx) from 1.1.6 to 1.2.26.
- [Release notes](https://github.com/lestrrat-go/jwx/releases)
- [Changelog](https://github.com/lestrrat-go/jwx/blob/v1.2.26/Changes)
- [Commits](lestrrat-go/jwx@v1.1.6...v1.2.26)

---
updated-dependencies:
- dependency-name: github.com/lestrrat-go/jwx
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #139 (3ab77e8) into main (777c318) will increase coverage by 1%.
The diff coverage is n/a.

@@         Coverage Diff          @@
##           main   #139    +/-   ##
====================================
+ Coverage    84%    85%    +1%     
====================================
  Files        28     28            
  Lines      1663   2398   +735     
====================================
+ Hits       1394   2019   +625     
- Misses      155    264   +109     
- Partials    114    115     +1     

see 28 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@theganyo theganyo changed the title update go (1.20) and github actions update go (1.20), github actions, and lestrat/jwx Jun 14, 2023
@theganyo
Copy link
Member Author

Do not merge.

goboring is only available <= 1.16. To upgrade Go, we will need to drop goboring support. see: https://hub.docker.com/r/goboring/golang/tags

@rockspore
Copy link
Contributor

@theganyo
Copy link
Member Author

Hmm. As far as I can tell, that doesn't seem to work either anymore.

@rockspore
Copy link
Contributor

Hmm. As far as I can tell, that doesn't seem to work either anymore.

It's terrible that they allow pulling a specific version but have no option to list all tags. I think it's better to ask in that group.

@theganyo
Copy link
Member Author

Goboring can now be enabled in any go build with GOEXPERIMENT=boringcrypto go build ....

@rockspore
Copy link
Contributor

The build is only supported in two architectures - amd64 and arm64. I suppose what has been released here is for amd64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants