Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export.sh #705

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix export.sh #705

wants to merge 1 commit into from

Conversation

Chris7X
Copy link

@Chris7X Chris7X commented Sep 28, 2023

Description

What's changed, or what was fixed?

  • Implemented a fix to handle and clean up URL inputs, ensuring they are properly formatted.
  • This fix removes special characters such as carriage return (\r), newline (\n), and tab (\t) from the URL.

Issues Fixed

Housekeeping

(please check all that apply [x], do not edit the text)

  • I have run all the tests locally and they all pass.
  • I have followed the relevant style guide for my changes.

Full Repo Validation Required

(please check all that apply [x], do not edit the text)

  • PR requires full pipeline run (Run for changes only by default).

CC: @apigee-devrel-reviewers

Fix issue curl: (3) URL rejected: Malformed input to a URL function
@google-cla
Copy link

google-cla bot commented Sep 28, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@OmidTahouri
Copy link
Collaborator

OmidTahouri commented Oct 3, 2023

Hi @Chris7X -- many thanks for the fix!

A couple of things to help move this forward:

  1. Please sign the CLA per the comment above
  2. Please amend the commit messages in the PR to conform to conventional commits by prefixing fix: -- e.g. fix: sackmesser export: whitespace characters

Out of curiousity, could you share which whitespace character was tripping you up and, if known, how the resource might have been created with that name (UI/API)?

Thanks!

@@ -51,8 +51,9 @@ loginfo "exporting to $export_folder"
mkdir -p "$export_folder"

sackmesser list "organizations/$organization/sharedflows" | jq -r -c '.[]|. | select((. | length) > 1)' | while read -r sharedflow; do
# Replacing white Spaces in the sharedflow name with %20
# Replacing white Spaces in the sharedflow name with %20, then removes special characters
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick, to be more accurate: "removes whitespace characters"

@@ -62,8 +63,9 @@ sackmesser list "organizations/$organization/sharedflows" | jq -r -c '.[]|. | se
done

sackmesser list "organizations/$organization/apis" | jq -r -c '.[]|.' | while read -r proxy; do
# Replacing white Spaces in the proxy name with %20
# Replacing white Spaces in the proxy name with %20, then removes special characters
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick, to be more accurate: "removes whitespace characters"

@OmidTahouri
Copy link
Collaborator

/gcbrun

@apigee-devrel-bot
Copy link

Pipeline Report

Pipeline Result Elapsed Wall Time
tools/apigee-sackmesser pass 301s
TOTAL PIPELINE pass 301s

View details in Cloud Build (permission required)

Commit version: c2318db

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants