Support for multiple/mixed attribute types. #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…table into multiple-roles
|
Okay, that's positive. This feels quite... ugly... to mutate global state in a class when a configuration flag is set. |
doconnor-clintel
commented
Dec 6, 2023
| <%= form_tag destroy_user_session_path(entity_id: "http://localhost:8020/saml/metadata"), method: :delete do %> | ||
| <%= submit_tag "Log out" %> | ||
| <% end %> | ||
| HOME | ||
| } | ||
| route "root to: 'home#index'" | ||
|
|
||
| # TODO: https://github.com/heartcombo/devise/blob/main/lib/generators/active_record/templates/migration.rb - string vs array |
There was a problem hiding this comment.
Here, potentially there should be some fancy string replacement done in the migration to make it
t.string :groups, array: true
doconnor-clintel
commented
Dec 6, 2023
doconnor-clintel
changed the title
…lly using the methods that exist
|
Annoying. However, that should be a OneLogin::RubySaml::Attributes object with those methods. |
adamstegman
reviewed
Dec 22, 2023
| @@ -1,3 +1,3 @@ | |||
| module DeviseSamlAuthenticatable | |||
| VERSION = "1.9.1" | |||
| VERSION = "2.0.0" | |||
There was a problem hiding this comment.
Is this actually a breaking change? It seems like it's backwards-compatible, which is great! In which case, we could release 1.10.0.
There was a problem hiding this comment.
I did this as a major version bump, as the reconfiguration of the attributes-map.yml is a bit of a pain; and people will have to adjust their custom attribute resolvers slightly.
spec/devise_saml_authenticatable/saml_mapped_attributes_spec.rb
Outdated
Show resolved
Hide resolved
…e have now defined which are arrays and which are singular values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised version of #159