Nullish check devtools.enabled #12093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgmolisani: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-client-docs pending review.Visit the deploys page to approve it
|
✅ Docs Preview ReadyNo new or changed pages found. |
🦋 Changeset detectedLatest commit: b7d000d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hey @mgmolisani 👋 Good catch! Would you mind adding a changeset to this PR? I'd be happy to merge and deploy this once that is in place. |
|
Added changeset |
jerelmiller
reviewed
Nov 11, 2024
Co-authored-by: Jerel Miller <[email protected]>
jerelmiller
reviewed
Nov 11, 2024
commit: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev tools has a new syntax and deprecated the old
connectToDevTools. However, the deprecation was implemented with|| connectToDevToolsinstead of?? connectToDevToolswhich results indevtools?.enabledto be overwritten byconnectToDevToolsfor any falsy value. IfconnectToDevToolsends up beingundefined, it overwritesfalsewhich then passes the guard on the next line erroneously and replaces the flag with__DEV__.In our environment this transpiles down to
globalThis.__DEV__ !== falseandglobalThis.__DEV__isundefinedso this effectively forces dev tools on even though we haddevtools.enabled = false