Skip to content

Commit

Permalink
Change warnings to todos
Browse files Browse the repository at this point in the history
  • Loading branch information
calvincestari committed Jan 5, 2024
1 parent a4ecf54 commit 2f8b56e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Tests/ApolloTests/GraphQLResultTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,6 @@ final class GraphQLResultTests: XCTestCase {

// MARK: Incremental merging tests

#warning("Need incremental merging tests here!")
// TODO: Need more incremental merging tests here

}
2 changes: 1 addition & 1 deletion apollo-ios/Sources/Apollo/GraphQLResult.swift
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ fileprivate extension DataDict {
}

let mergedData = try pathDataDict._data.merging(newDataDict._data) { current, new in
#warning("This is a hack fix for __typename being returned with fragments, need a proper solution!")
// TODO: This is a quick fix for __typename being returned with fragments, needs a rethink!
if current != new {
throw Error.cannotOverwriteData(current, new)
}
Expand Down

0 comments on commit 2f8b56e

Please sign in to comment.