tests: Add merged selection deferred test case #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvincestari
commented
Nov 22, 2023
| @@ -63,7 +63,7 @@ extension GraphQLResult { | |||
|
|
|||
| private func convert(value: Any) -> Any { | |||
| var val: Any = value | |||
| if let value = value as? ApolloAPI.DataDict { | |||
| if let value = value as? DataDict { | |||
There was a problem hiding this comment.
@BobaFetters I had to make this change to get the cocoapods codegen test configuration project to pass. The change makes sense but how have other PRs been building, including the one that included this change originally?
There was a problem hiding this comment.
It's because the Codegen Test Configurations job was skipped in that PR. We'll need to revise the logic that turns that on/off.
AnthonyMDev
approved these changes
Nov 28, 2023
calvincestari
deleted the
defer-test-named-fragment-matching-type-case
branch
BobaFetters
pushed a commit
that referenced
this pull request
Nov 28, 2023
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Nov 28, 2023
BobaFetters
pushed a commit
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AnthonyMDev here's the test case we spoke about today. It passes but I'm not sure if it's correct; it's throwing me off that the deferred fragment is a merged selection on line 6778.