Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Renovate dependency updates #170

Merged
merged 10 commits into from
Dec 1, 2023

Conversation

@calvincestari calvincestari force-pushed the renovate/deps-update-20231201 branch from 291545a to 3ae2985 Compare December 1, 2023 18:37
@calvincestari
Copy link
Member Author

We have CI tests that validate any changes to the GraphQLCompiler JS package but nothing automated for the documentation generator, so I have manually confirmed that there are no errors during the swift run DocumentationGenerator command from the docs renderer package changes.

@AnthonyMDev
Copy link
Contributor

AnthonyMDev commented Dec 1, 2023

If there are changes to the JS Frontend package, we need to actually run rollup and then run the Swift codegen tests with the new code in the ApolloCodegenFrontendBundle. If the tests pass after doing that, I'm good to ship this!

@calvincestari
Copy link
Member Author

If there are changes to the GraphQL-js package, we need to actually run rollup and then run the Swift codegen tests with the new code in the ApolloCodegenFrontendBundle. If the tests pass after doing that, I'm good to ship this!

That's a very good point but there are no changes to the bundle after running the auto_rollup script so nothing to re-test.

@calvincestari calvincestari merged commit fd9f966 into main Dec 1, 2023
14 checks passed
@calvincestari calvincestari deleted the renovate/deps-update-20231201 branch December 1, 2023 19:02
BobaFetters pushed a commit to apollographql/apollo-ios that referenced this pull request Dec 1, 2023
BobaFetters pushed a commit to apollographql/apollo-ios-codegen that referenced this pull request Dec 1, 2023
BobaFetters pushed a commit that referenced this pull request Dec 1, 2023
d09a8c6 chore(deps): Renovate dependency updates (#170)

git-subtree-dir: apollo-ios
git-subtree-split: d09a8c6
BobaFetters pushed a commit that referenced this pull request Dec 1, 2023
git-subtree-dir: apollo-ios
git-subtree-mainline: eee3801
git-subtree-split: d09a8c6
BobaFetters pushed a commit that referenced this pull request Dec 1, 2023
b76b8853 chore(deps): Renovate dependency updates (#170)

git-subtree-dir: apollo-ios-codegen
git-subtree-split: b76b8853ff24909d8799d30122e6f89de0b0b8ff
BobaFetters pushed a commit that referenced this pull request Dec 1, 2023
…y updates

git-subtree-dir: apollo-ios-codegen
git-subtree-mainline: fe89764
git-subtree-split: b76b8853ff24909d8799d30122e6f89de0b0b8ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants