ci: Adds frontend bundle validation job #193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AnthonyMDev here is a CI job we can use to build trust in the dependency updates to the GraphQLCompiler module. Once this is merged if any new dependency updates pass all tests then we should have confidence that they're OK to merge without needing to do any manual validation. |
calvincestari
force-pushed
the
ci/graphqlcompiler-bundle-validation
branch
from
839ca9a to
d172746
Compare
|
Closing this in favour of #181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With dependency updates being automated and having a few to deal with lately it's easy to miss something in the JS bundle, aka. GraphQLCompiler; especially since it is a manual process to build and compile the changes into Swift.
This PR adds a bundle validation step that will install all the requisite node packages, build the bundle and then fail if there is a git diff which would indicate that there are changes we haven't included that should be.