Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update to graphql-js 17.0.0-alpha.3 #194

Merged
merged 6 commits into from
Dec 13, 2023
Merged

chore(deps): Update to graphql-js 17.0.0-alpha.3 #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2003583
Update to graphql-js 17.0.0-alpha.3
calvincestari Dec 8, 2023
3739c34
Fixes build error during rollup replace
calvincestari Dec 8, 2023
260112a
Update frontend bundle
calvincestari Dec 8, 2023
772c2c0
Block unit tests until bundle validation is done
calvincestari Dec 8, 2023
cd91a81
Revert "Block unit tests until bundle validation is done"
calvincestari Dec 13, 2023
764e73e
Merge branch 'main' into deps/graphql-js-17-alpha-3
calvincestari Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apollo-ios-codegen/Sources/GraphQLCompiler/ApolloCodegenFrontendBundle.swift
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apollo-ios-codegen/Sources/GraphQLCompiler/JavaScript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"npm": ">=7"
},
"dependencies": {
"graphql": "17.0.0-alpha.2",
"graphql": "17.0.0-alpha.3",
"tslib": "^2.3.0"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion apollo-ios-codegen/Sources/GraphQLCompiler/JavaScript/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const options = {
}),
replace({
preventAssignment: true,
"process.env.NODE_ENV": JSON.stringify("production"),
"globalThis.process.env.NODE_ENV": JSON.stringify("production"),
Copy link
Member Author

@calvincestari calvincestari Dec 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing an error but it is also incorrect because had there not been any error it would have resulted in globalThis.production which is not valid. I don't have the full context for our rollup configuration but based on what we're replacing we're effectively saying "we don't care what the environment is, always behave as if it's production". This gets us back to that with the latest code in graphl-js which changed between alpha.2 and alpha.3.

Note that the replace configuration wouldn't have worked with the alpha.2 code anyways but I believe the intention that we always want to operate in a "production" environment is correct for our use of the JS code.

}),
terser({
keep_classnames: true,
Expand Down