Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @import directive #228

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Add @import directive #228

merged 4 commits into from
Jan 8, 2024

Conversation

AnthonyMDev
Copy link
Contributor

@AnthonyMDev AnthonyMDev commented Jan 8, 2024

This adds a new @import(module:) directive that can be used when defining operations or fragments to be used as input to the Apollo iOS Codegen Engine.

This PR only adds the new directive to the graphql-js frontend wrapper.

In following PRs:

  • The @import statement directives will be stripped from the definition string that is sent on network requests (and used in persisted query lists). (done in Strip @import directive from definition source #229)
  • Each @import directive instance will add an import statement to the generated Swift definition file that imports a module with the value of the module argument.

@AnthonyMDev AnthonyMDev requested a review from a team as a code owner January 8, 2024 20:45
Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for eclectic-pie-88a2ba canceled.

Name Link
🔨 Latest commit 5b2b134
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-pie-88a2ba/deploys/659c6727fcd3fb000853d028

@AnthonyMDev AnthonyMDev self-assigned this Jan 8, 2024
Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AnthonyMDev AnthonyMDev enabled auto-merge (squash) January 8, 2024 21:21
@AnthonyMDev AnthonyMDev merged commit a2e389b into main Jan 8, 2024
14 checks passed
@AnthonyMDev AnthonyMDev deleted the import-directive branch January 8, 2024 21:21
BobaFetters pushed a commit that referenced this pull request Jan 8, 2024
BobaFetters pushed a commit to apollographql/apollo-ios-codegen that referenced this pull request Jan 8, 2024
BobaFetters pushed a commit that referenced this pull request Jan 8, 2024
7b7b81bc Add @import directive (#228)

git-subtree-dir: apollo-ios-codegen
git-subtree-split: 7b7b81bcdc99489465a98395c6b04ce1df50fcd5
BobaFetters pushed a commit that referenced this pull request Jan 8, 2024
git-subtree-dir: apollo-ios-codegen
git-subtree-mainline: 2d393cb
git-subtree-split: 7b7b81bcdc99489465a98395c6b04ce1df50fcd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants