Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate localCacheMutation selectionSetInitializer option #350

Conversation

AnthonyMDev
Copy link
Contributor

@AnthonyMDev AnthonyMDev commented May 1, 2024

TL;DR

Updated the selection set initializers configuration to always generate initializers for local cache mutations

What changed?

  • Removed the explicit configuration for local cache mutations in the ApolloCodegenConfiguration struct.
  • Modified the SelectionSetInitializers enum to always generate initializers for local cache mutations
  • Deprecated the localCacheMutations option in SelectionSetInitializers.

How to test?

No specific test instructions provided.

Why make this change?

The change was made to streamline the configuration process and ensure consistent generation of initializers for local cache mutations.


@AnthonyMDev AnthonyMDev marked this pull request as ready for review May 1, 2024 01:10
@AnthonyMDev AnthonyMDev force-pushed the Field_Merging_5_x_make_experimental branch from 0c1dcdb to 7ea0d68 Compare May 1, 2024 01:20
@AnthonyMDev AnthonyMDev force-pushed the Field_Merging_6_x_deprecate_initializer_localCacheMutations branch from 8319c24 to 632d2d8 Compare May 1, 2024 01:20
@AnthonyMDev AnthonyMDev force-pushed the Field_Merging_5_x_make_experimental branch from 7ea0d68 to 1395739 Compare July 16, 2024 18:42
@AnthonyMDev AnthonyMDev force-pushed the Field_Merging_6_x_deprecate_initializer_localCacheMutations branch from 632d2d8 to 363d0dc Compare July 16, 2024 18:44
@AnthonyMDev AnthonyMDev force-pushed the Field_Merging_5_x_make_experimental branch from 1395739 to df8edc2 Compare July 16, 2024 19:51
@AnthonyMDev AnthonyMDev force-pushed the Field_Merging_6_x_deprecate_initializer_localCacheMutations branch from 363d0dc to 0dbfb72 Compare July 16, 2024 19:52
@AnthonyMDev AnthonyMDev marked this pull request as draft July 29, 2024 21:19
@AnthonyMDev
Copy link
Contributor Author

This was merged in as part of #431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant