Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back deprecated CodingKey for localCacheMutation in selectionSetInitializers #467

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Bring back deprecated CodingKey for localCacheMutation in selectionSetInitializers #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions Tests/ApolloCodegenTests/ApolloCodegenConfigurationCodableTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,24 @@ class ApolloCodegenConfigurationCodableTests: XCTestCase {
expect(decoded).to(equal(expected))
}

func test__decode_selectionSetInitializers__givenLocalCacheMutations_shouldReturnIgnoreOption() throws {
// given
let subject = """
{
"localCacheMutations": true
}
""".asData

// when
let decoded = try JSONDecoder().decode(
ApolloCodegenConfiguration.SelectionSetInitializers.self,
from: subject
)

// then
expect(decoded).to(equal([]))
}

// MARK: - OperationDocumentFormat Tests

func encodedValue(_ case: ApolloCodegenConfiguration.OperationDocumentFormat) -> String {
Expand Down
4 changes: 4 additions & 0 deletions apollo-ios-codegen/Sources/ApolloCodegenLib/ApolloCodegenConfiguration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,6 +1263,10 @@ extension ApolloCodegenConfiguration.SelectionSetInitializers {
case operations
case namedFragments
case definitionsNamed

/// Deprecated
/// Local Cache Mutations will now always have initializers generated.
case localCacheMutations
}

public init(from decoder: any Decoder) throws {
Expand Down
Loading