fix: Update Codegen generated SPM swift-tools-version check #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyMDev
approved these changes
Sep 18, 2024
Base automatically changed from
ci/fix-test-result-failure-notification
to
main
September 18, 2024 16:37
calvincestari
force-pushed
the
fix/codegen-spm-generated-swift-tools-version
branch
from
ff4a7a6 to
2fc5a2f
Compare
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
@AnthonyMDev, I've instead removed the two 'boilerplate' tests and regenerated the internal unit test projects in the latest PR commits. |
calvincestari
deleted the
fix/codegen-spm-generated-swift-tools-version
branch
BobaFetters
pushed a commit
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
swift-tools-versionnumber in generated package manifests was recently updated in #479. We didn't update the test though; it's debatable whether this test actually has much value to be honest. Also related to #483.