Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Main branch health failure logs #523

Merged
merged 3 commits into from
Oct 29, 2024
Merged

ci: Main branch health failure logs #523

merged 3 commits into from
Oct 29, 2024

Conversation

calvincestari
Copy link
Member

I noticed that we've been having some failures on the Main Branch Health job but the test logs aren't being saved.

  • Adds the failure() condition so that the save steps are still run when the job fails
  • Adds pagination tests (not sure why these weren't in here, maybe just forgot when the pagination lib was added)
  • Some clean up

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Oct 28, 2024 •
edited
Loading

✅ Docs Preview Ready

No new or changed pages found.

@netlify Netlify
Copy link

netlify bot commented Oct 28, 2024 •
edited
Loading

✅ Deploy Preview for apollo-ios-docc canceled.

Name Link
🔨 Latest commit b4cb12e
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docc/deploys/672020860484390008e0d86b

@netlify Netlify
Copy link

netlify bot commented Oct 28, 2024 •
edited
Loading

✅ Deploy Preview for eclectic-pie-88a2ba canceled.

Name Link
🔨 Latest commit b4cb12e
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-pie-88a2ba/deploys/67202086d6e515000853b621

@calvincestari
Copy link
Member Author

Merging without review since this change only affects a nightly build action.

@calvincestari calvincestari merged commit 34b608e into main Oct 29, 2024
32 checks passed
@calvincestari calvincestari deleted the ci/main-branch-health branch October 29, 2024 16:05
BobaFetters pushed a commit that referenced this pull request Oct 29, 2024
@calvincestari
ci: Main branch health failure logs (#523)
a933272
@calvincestari calvincestari mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobaFetters BobaFetters Awaiting requested review from BobaFetters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calvincestari @svc-apollo-docs