Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Assign websocket callback queue before connecting #529

Merged
merged 2 commits into from
Oct 31, 2024
Merged

fix: Assign websocket callback queue before connecting #529

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
740ad68
Assign callback queue before connecting
calvincestari Oct 31, 2024
bcf47d8
Add comment
calvincestari Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apollo-ios/Sources/ApolloWebSocket/WebSocketTransport.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,14 @@ public class WebSocketTransport {
self.addApolloClientHeaders(to: &self.websocket.request)

self.websocket.delegate = self
// Keep the assignment of the callback queue before attempting to connect. There is the
// potential of a data race if the connection fails early and the disconnect logic reads
// the callback queue while it's being set.
self.websocket.callbackQueue = processingQueue

if config.connectOnInit {
self.websocket.connect()
}
self.websocket.callbackQueue = processingQueue
}

public func isConnected() -> Bool {
Expand Down
Loading