Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove SummitCallouts #534

Merged

Conversation

Meschreiber
Copy link
Contributor

@Meschreiber Meschreiber commented Nov 6, 2024

Removes callouts for iOS Summit sessions.

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Nov 6, 2024

✅ Docs Preview Ready

Configuration
{
  "repoOverrides": {
    "apollographql/apollo-ios-dev@main": {
      "remote": {
        "owner": "Meschreiber",
        "repo": "apollo-ios-dev",
        "branch": "ms/remove-summit-callouts"
      }
    }
  }
}
Name Link

Commit

41af6d7

Preview

https://www.apollographql.com/docs/deploy-preview/3dff020fdfb88cb41f6c

Build ID

3dff020fdfb88cb41f6c

File Changes

0 new, 2 changed, 0 removed
* (developer-tools)/ios/(latest)/get-started.mdx
* (developer-tools)/ios/(latest)/index.mdx

Pages

2


2 pages published. Build will be available for 30 days.

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for apollo-ios-docc ready!

Name Link
🔨 Latest commit 41af6d7
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docc/deploys/672cd899ce7d5c0008b8414e
😎 Deploy Preview https://deploy-preview-534--apollo-ios-docc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for eclectic-pie-88a2ba ready!

Name Link
🔨 Latest commit 41af6d7
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-pie-88a2ba/deploys/672cd899ffc7aa00087ca0c2
😎 Deploy Preview https://deploy-preview-534--eclectic-pie-88a2ba.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@calvincestari
Copy link
Member

calvincestari commented Nov 7, 2024

@Meschreiber - we can ignore the failed "Check PR Metadata" check but there are also failed Netlify checks; do we need to be concerned about those? I did check the modified pages (index and get-started) in the deploy preview and they both render correctly so not sure what the failed Netlify checks are about.

@Meschreiber
Copy link
Contributor Author

Meschreiber commented Nov 7, 2024

Thanks @calvincestari ! Those Netlify checks are for the legacy docs site--I'll remove the associated netlify.toml.

@Meschreiber
Copy link
Contributor Author

Hmm, I think those checks should go away with future PRs, but will look into if they don't.

In the meanwhile, would you mind merging when you get a chance please? I don't have write access for the repo. TIA!

@apollographql apollographql deleted a comment from Meschreiber Nov 7, 2024
@BobaFetters BobaFetters merged commit 3e448bf into apollographql:main Nov 7, 2024
29 checks passed
BobaFetters pushed a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants