feature: @oneOf input object support #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for oneOf from graphql-js and new template renderer
✅ Docs Preview ReadyNo new or changed pages found. |
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BobaFetters
commented
Nov 13, 2024
AnthonyMDev
approved these changes
Nov 13, 2024
apollo-ios-codegen/Sources/ApolloCodegenLib/Templates/OneOfInputObjectTemplate.swift
Outdated
Show resolved
Hide resolved
Updating the SPMInXcodeProject codegen config to commit the animal kingdom package.swift and use local version of library
This reverts commit bb3cce4.
calvincestari
approved these changes
Nov 14, 2024
| @@ -57,7 +57,7 @@ | |||
| "path" : "./AnimalKingdomAPI", | |||
| "moduleType" : { | |||
| "swiftPackageManager" : { | |||
|
|
|||
There was a problem hiding this comment.
Should this one be changed to the new swiftPackage too?
There was a problem hiding this comment.
Yea might as well, not actually required since this gets decoded into the new one but worth going ahead and switching it.
There was a problem hiding this comment.
Actually looks like this one may require the change because of the need for the local path causing the ci failure
|
Looks like there is still a CI test failure - is that CI related or more work to be done? |
BobaFetters
added a commit
to apollographql/apollo-ios
that referenced
this pull request
Dec 2, 2024
BobaFetters
added a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Dec 2, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Dec 2, 2024
git-subtree-dir: apollo-ios git-subtree-mainline: 4c87fc4 git-subtree-split: daa2c1e408304c4943d12f5f1445b4fb2e7f4254
BobaFetters
pushed a commit
that referenced
this pull request
Dec 2, 2024
…pport git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 8c28971 git-subtree-split: 461d092e5835dcfadf43aaa37606305582d1ac59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for @OneOf Input Objects, more info can be found in the official RFC here: graphql/graphql-spec#825
Closes apollographql/apollo-ios#3430