ci: Minor job improvements #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs Preview ReadyNo new or changed pages found. |
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
calvincestari
force-pushed
the
ci/auto-rollup-npm-install
branch
from
05f4297 to
bf310d5
Compare
calvincestari
changed the title
AnthonyMDev
approved these changes
Nov 19, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Nov 19, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Nov 19, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Nov 19, 2024
759edca9 ci: Minor job improvements (#541) git-subtree-dir: apollo-ios-codegen git-subtree-split: 759edca95ec38433bb3a6ec509befa82a784ad50
BobaFetters
pushed a commit
that referenced
this pull request
Nov 19, 2024
git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 56abd44 git-subtree-split: 759edca95ec38433bb3a6ec509befa82a784ad50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a couple changes to our CI jobs to hopefully speed up total CI time and reduce mistakes:
npm installto the common script so that we don't need to do it separately as part of the JS frontend bundle update. This should mean less mistakes by missing a step that is needed to install the latest package updates. Stems from the secops PR that failed CI due to the bundle needing to be updated. Couldn't understand why I wasn't getting any changes, then realized I needed to install the package updates before regenerating the bundle. This makes it a common step now so that should all be handled for us.