fix: Changes URLRequest cache policy default
#550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs Preview ReadyNo new or changed pages found. |
✅ Deploy Preview for eclectic-pie-88a2ba ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for apollo-ios-docc canceled.
|
BobaFetters
pushed a commit
that referenced
this pull request
Dec 6, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Dec 6, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Dec 6, 2024
f0b2a850 fix: Changes `URLRequest` cache policy default (#550) git-subtree-dir: apollo-ios git-subtree-split: f0b2a850945fe070b92a054584e55827fa4a0b15
BobaFetters
pushed a commit
that referenced
this pull request
Dec 6, 2024
…default git-subtree-dir: apollo-ios git-subtree-mainline: b5a267a git-subtree-split: f0b2a850945fe070b92a054584e55827fa4a0b15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apollographql/apollo-ios#3483.
The differing behaviour is in whether the cache policy respects the original Cache-Control header directive re. expiration:
useProtocolCachePolicyis defined as "Use the caching logic defined in the protocol implementation, if any, for a particular URL load request."returnCacheDataElseLoadis defined as "Use existing cache data, regardless or age or expiration date, loading from originating source only if there is no cached data."