feature: Adds support for GraphQL over HTTP media type #558
Conversation
✅ Docs Preview ReadyNo new or changed pages found. |
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Done. |
|
|
||
| // This test is odd because you might assume it would fail but there is no content-type checking on standard | ||
| // GraphQL response parsing. So this test is here to ensure that existing behaviour does not change. | ||
| func test__response__givenUnknownContentType_shouldNotFail() throws { |
There was a problem hiding this comment.
I've added tests to keep the existing behaviour of standard GraphQL response parsing including this odd one.
| @@ -59,7 +59,7 @@ struct MultipartResponseDeferParser: MultipartResponseSpecificationParser { | |||
| for dataLine in chunk.components(separatedBy: Self.dataLineSeparator.description) { | |||
| switch DataLine(dataLine.trimmingCharacters(in: .newlines)) { | |||
| case let .contentHeader(type): | |||
| guard type == "application/json" else { | |||
| guard type == "application/graphql-response+json" || type == "application/json" else { | |||
There was a problem hiding this comment.
We should create a helper method for this. We're doing string comparisons against strings that are really constants. And we're doing the same comparison in two places. This is prone to future bugs.
We should store the constants as StaticStrings and have a helper method to check the content header.
There was a problem hiding this comment.
I'll put this PR back into draft and make that change when I get back.
Closes apollographql/apollo-ios#3485.
application/json. Instead it simply attempts to deserialize anything as if it is JSON. It's only in the multipart parsers that we do a content type check for the chunks. @AnthonyMDev - this hasn't been an issue for now but do you think we should add this check? I'm inclined to leave the standard parser as it is.