-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Identifiable conformance for Named Fragments #595
Merged
calvincestari
merged 4 commits into
apollographql:main
from
x-sheep:identifiable-fragments
Jan 29, 2025
Merged
feature: Identifiable conformance for Named Fragments #595
calvincestari
merged 4 commits into
apollographql:main
from
x-sheep:identifiable-fragments
Jan 29, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-ios-docc pending review.Visit the deploys page to approve it
|
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removed
Build ID: fd5459861483fffce9f398b0 URL: https://www.apollographql.com/docs/deploy-preview/fd5459861483fffce9f398b0 |
Tests/ApolloCodegenTests/CodeGeneration/Templates/FragmentTemplateTests.swift
Outdated
Show resolved
Hide resolved
calvincestari
approved these changes
Jan 28, 2025
…lateTests.swift Co-authored-by: Calvin Cestari <[email protected]>
AnthonyMDev
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Thanks so much @x-sheep
BobaFetters
pushed a commit
that referenced
this pull request
Jan 29, 2025
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Jan 29, 2025
BobaFetters
pushed a commit
that referenced
this pull request
Jan 29, 2025
4b1bc5bc feature: Identifiable conformance for Named Fragments (#595) git-subtree-dir: apollo-ios-codegen git-subtree-split: 4b1bc5bcdecab067326e4ba77e651f662d1a1d19
BobaFetters
pushed a commit
that referenced
this pull request
Jan 29, 2025
…ce for Named Fragments git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 6f6c623 git-subtree-split: 4b1bc5bcdecab067326e4ba77e651f662d1a1d19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the same as #584, except for generated NamedFragment types.