Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: InputObject GraphQLNullable subscript #596

Merged
merged 3 commits into from
Jan 31, 2025
Merged

fix: InputObject GraphQLNullable subscript #596

merged 3 commits into from
Jan 31, 2025

Conversation

calvincestari
Copy link
Member

Fixes apollographql/apollo-ios#3506.

InputObject needed a GraphQLNullable-specific subscript to prevent nil value keys being forcefully unwrapped.

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Jan 31, 2025 •
edited
Loading

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 14 changed, 0 removed 
* (developer-tools)/ios/(latest)/tutorial/tutorial-add-graphql-schema.mdx
* (developer-tools)/ios/(latest)/tutorial/tutorial-add-more-info-to-list.mdx
* (developer-tools)/ios/(latest)/tutorial/tutorial-authenticate-operations.mdx
* (developer-tools)/ios/(latest)/tutorial/tutorial-complete-details-view.mdx
* (developer-tools)/ios/(latest)/tutorial/tutorial-configure-project.mdx
* (developer-tools)/ios/(latest)/tutorial/tutorial-connect-queries-to-ui.mdx
* (developer-tools)/ios/(latest)/tutorial/tutorial-define-additional-mutations.mdx
* (developer-tools)/ios/(latest)/tutorial/tutorial-execute-first-query.mdx
* (developer-tools)/ios/(latest)/tutorial/tutorial-first-mutation.mdx
* (developer-tools)/ios/(latest)/tutorial/tutorial-introduction.mdx
* (developer-tools)/ios/(latest)/tutorial/tutorial-paginate-results.mdx
* (developer-tools)/ios/(latest)/tutorial/tutorial-running-code-generation.mdx
* (developer-tools)/ios/(latest)/tutorial/tutorial-subscriptions.mdx
* (developer-tools)/ios/(latest)/tutorial/tutorial-write-your-first-query.mdx

Build ID: 6e12145074e68242d842ea7e

URL: https://www.apollographql.com/docs/deploy-preview/6e12145074e68242d842ea7e

@netlify Netlify
Copy link

netlify bot commented Jan 31, 2025 •
edited
Loading

✅ Deploy Preview for apollo-ios-docc canceled.

Name Link
🔨 Latest commit 07200a1
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docc/deploys/679d3ced8fe2d40008523e81

@calvincestari calvincestari force-pushed the fix/inputobject-nullable-accessor branch from b0b9858 to 1f7483d Compare January 31, 2025 20:47
@calvincestari
Copy link
Member Author

Going to rebase this onto #597 once that's merged into main, to fix the CI errors.

@calvincestari calvincestari force-pushed the fix/inputobject-nullable-accessor branch from 1f7483d to 07200a1 Compare January 31, 2025 21:13
@calvincestari calvincestari merged commit 07de3dd into main Jan 31, 2025
31 checks passed
@calvincestari calvincestari deleted the fix/inputobject-nullable-accessor branch January 31, 2025 22:18
BobaFetters pushed a commit that referenced this pull request Jan 31, 2025
@calvincestari
fix: InputObject GraphQLNullable subscript (#596)
de2b3cc
BobaFetters pushed a commit to apollographql/apollo-ios that referenced this pull request Jan 31, 2025
@calvincestari
fix: InputObject GraphQLNullable subscript (apollographql/apollo-ios-…
129c16a 
…dev#596)
BobaFetters pushed a commit that referenced this pull request Jan 31, 2025
Squashed 'apollo-ios/' changes from e98e9d3b..129c16a1
f8d3563 
129c16a1 fix: InputObject GraphQLNullable subscript (#596)

git-subtree-dir: apollo-ios
git-subtree-split: 129c16a14210168665ea5f41e8060f8528f99cdd
BobaFetters pushed a commit that referenced this pull request Jan 31, 2025
split: apollo-ios - PR #596 - fix: InputObject GraphQLNullable subscript
3643261 
git-subtree-dir: apollo-ios
git-subtree-mainline: de2b3cc
git-subtree-split: 129c16a14210168665ea5f41e8060f8528f99cdd
@calvincestari calvincestari mentioned this pull request Jan 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyMDev AnthonyMDev AnthonyMDev approved these changes

@BobaFetters BobaFetters Awaiting requested review from BobaFetters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessing an unset deprecated field in input causes a crash
3 participants
@calvincestari @svc-apollo-docs @AnthonyMDev