fix: SelectionSet equality in 1.x
#771
Open
+1,413
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 3 changed, 0 removedBuild ID: f2e31548e29f16e8906b2e12 URL: https://www.apollographql.com/docs/deploy-preview/f2e31548e29f16e8906b2e12 |
calvincestari
commented
Sep 29, 2025
| __data[key] | ||
| } | ||
|
|
||
| public static func == (lhs: MockSelectionSet, rhs: MockSelectionSet) -> Bool { |
There was a problem hiding this comment.
SelectionSet now has it's own equality implementation.
calvincestari
force-pushed
the
fix/v1-equality-check
branch
from
52a7915 to
893a4f5
Compare
calvincestari
force-pushed
the
fix/v1-equality-check
branch
from
87a2466 to
ab8f785
Compare
AnthonyMDev
approved these changes
Oct 8, 2025
| } | ||
| } | ||
|
|
||
| @_disfavoredOverload |
There was a problem hiding this comment.
I accidentally left this in when I was trying something else. We can remove the @_disfavoredOverload here
| await fulfillment(of: [updateCompletedExpectation], timeout: 1.0) | ||
| } | ||
|
|
||
| func test__equatable__givenFailingModelFromCI_sameValue_shouldBeEqual() throws { |
There was a problem hiding this comment.
We should change the name of this to what it's actually testing, which I'm pretty sure is list of nested entities. We could probably remove the irrelevant fields also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to apollographql/apollo-ios#3579 but targets a fix in the 1.0 branch.
An
Optionaltype wrapped byAnyHashableexhibits weird behaviour when checking equality of a non-optional type, eg:Swift==Swift?. The fix in 1.x is to recover the type data lost through usingAnyHashableinDataDictand then cast the field data as the field's concrete type for equality checks.