Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MegaIssue: Cache improvements #2331

Open
15 of 41 tasks
martinbonnin opened this issue Jun 4, 2020 · 5 comments
Open
15 of 41 tasks

MegaIssue: Cache improvements #2331

martinbonnin opened this issue Jun 4, 2020 · 5 comments

Comments

@martinbonnin
Copy link
Contributor

martinbonnin commented Jun 4, 2020

This is an generic issue to list ideas/improvements that can be done to the normalized cache

@martinbonnin martinbonnin changed the title [Normalized Cache] Allow to set a max size [Cache] Cache improvements Jun 19, 2020
@martinbonnin martinbonnin mentioned this issue Jul 6, 2020
15 tasks
@ychescale9
Copy link
Contributor

I assume this requires weigher API if you're still planning to use Dropbox/Store/cache? Are there any other features / API changes you'd like to see from cache to enable these improvements?

@martinbonnin
Copy link
Contributor Author

@ychescale9 I think multiplatform is a big one. I don't think Store supports multiplatform yet?

Multiplatform would be required for the LruNormalizedCache to be used from apollo-runtime-kotlin

@ychescale9
Copy link
Contributor

@martinbonnin multiplatform support for Store itself has been deprioritized. I’m keen to push for KMP support for the cache module first which currently is JVM only and does not depend on coroutines, so we can unblock apollo-android.

@martinbonnin
Copy link
Contributor Author

That's be great! I think cache4 is all we need. I don't think we use store at the moment.

@ahetawal-p
Copy link

@martinbonnin Could this be also part of these improvements related to cache eviction:
https://github.com/apollographql/apollo-android/issues/2507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants