[apollo-normalized-cache] Convert remaining Java classes to Kotlin #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
commented
Jul 15, 2020
...ed-cache/src/main/java/com/apollographql/apollo/cache/normalized/internal/NoOpApolloStore.kt
Show resolved
Hide resolved
martinbonnin
commented
Jul 15, 2020
...ed-cache/src/main/java/com/apollographql/apollo/cache/normalized/internal/NoOpApolloStore.kt
Outdated
Show resolved
Hide resolved
martinbonnin
commented
Jul 15, 2020
...ed-cache/src/main/java/com/apollographql/apollo/cache/normalized/internal/NoOpApolloStore.kt
Show resolved
Hide resolved
sav007
reviewed
Jul 19, 2020
...alized-cache/src/main/java/com/apollographql/apollo/cache/normalized/internal/SimpleStack.kt
Show resolved
Hide resolved
sav007
approved these changes
Jul 19, 2020
|
Superseded by #2457 (same commits but using a local branch and not from my fork so that I could merge the dependant PR first) |
martinbonnin
deleted the
feature-2144/convert-apollo-normalized-cache-to-kotlin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a plain Java -> Kotlin conversion. There should be (almost) no behaviour change (see comments in the diff for more details).
Next steps:
multiplatformpluginApolloStoreandApolloStoreOperationtojvmMain. These two classes are based onExecutorsandAtomicReferencesso they will be hard to convert to KMP. I think we can use another API for KMP, based on coroutines.LruNormalizedCachetojvmMainas well as it depends oncom.nytimes.android:cache, which is not KMPcom.dropbox.mobile.store:cache4becomes KMP (MegaIssue: Cache improvements #2331 (comment)), move everything tocommonMain, potentially in another module?