[apollo-normalized-cache] Add the Kotlin multiplatform plugin #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
changed the title
martinbonnin
changed the title
sav007
approved these changes
Jul 19, 2020
sav007
reviewed
Jul 19, 2020
|
|
||
| fun map(): Map<String, Any?> { | ||
| return Collections.unmodifiableMap(buffer) | ||
| return buffer.toList().sortedBy { it.first }.toMap() |
There was a problem hiding this comment.
nit: should buffer.toSortedMap() do the same?
There was a problem hiding this comment.
I didn't find a toSortedMap for iOS :(
martinbonnin
force-pushed
the
feature-2144/make-apollo-normalized-cache-multiplatform
branch
from
3dca6a6 to
ad59c55
Compare
martinbonnin
merged commit c797786
into
feature-2144/convert-apollo-normalized-cache-to-kotlin
martinbonnin
deleted the
feature-2144/make-apollo-normalized-cache-multiplatform
branch
martinbonnin
added a commit
that referenced
this pull request
Jul 20, 2020
* Rename .java to .kt * convert ResponseNormalizer to Kotlin * Rename .java to .kt * convert SimpleStack to Kotlin * Rename .java to .kt * convert NoOpApolloStore to Kotlin * make it compile * make it compile * unbreak tests * add comments * code review * [apollo-normalized-cache] Add the Kotlin multiplatform plugin (#2447) * introduce the plugin multiplatform plugin * remove some java imports * remove the fieldNameComparator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependent on #2446
It adds the Kotlin multiplatform plugin to
apollo-normalized-cache. EverythingApolloStoreandLruNormalizedCacheis still injvmMaindue to JVM dependencies.