🗃️ initial pass at a CacheControl document #4009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
BoD
reviewed
Apr 11, 2022
| extend type Speaker @cacheControl(maxAge: 3600) | ||
| ``` | ||
|
|
||
| Or if introspection ever supports directive usages, it could be retrieved (and cached) at runtime. |
|
|
||
| To keep the database size manageable, the Records can be serialized in binary format, skipping the Json overhead and compressing timestamps when the same timestamp is used for multiple fields. | ||
|
|
||
| To avoid storing another Long in the DB, it is proposed to define cache control rules in the client. Ideally using directives: |
There was a problem hiding this comment.
Sorry I'm not sure I understand this sentence: we still need to store the dates in the db right?
There was a problem hiding this comment.
Yes, date but not date + maxAge (so it saves 64bits). I'll update that part.
ynkm169
reviewed
Apr 10, 2023
|
|
||
| Date sounds required in all cases. MaxAge is required if we want to store that information when coming from the server but could be spared if the rules are defined on the client side. | ||
|
|
||
| Because any operation can query any field, this information needs to be stored per-field. This is the hard part. Adding one (or several) 64 bit timestamp for each field might double (or worse) the size of the cache. On the other hand a lot of fields will share the same timestamp, opening opportunities for compression (see #possible-optimisations). |
There was a problem hiding this comment.
this information needs to be stored per-field
Question, does this mean the following code need to store expiry for all 3 fields? (name, bio, twitter) Wouldn't an expiry only on Speaker itself suffice?
type Speaker @cacheControl(maxAge: 3600) {
name: String!
bio: String!
twitter: String
}
ynkm169
reviewed
Apr 10, 2023
|
|
||
| - OS I/O cache | ||
| - SQLite page cache | ||
| - Apollo Memory cache |
There was a problem hiding this comment.
Clarification question:
If we don't use SQL cache at all, will we be able to use expiry with just the memory cache?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3566