Track @ApolloExperimental symbols in public API
#6416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: de6899c114e7e6944e492a42 |
martinbonnin
force-pushed
the
fix-opt-in-annotations
branch
from
d27737e to
648fbf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #6407: we also use
@ApolloExperimentalsymbol accross module boundaries so we need to track those as well.In a perfect world, we need a specific
@OptInsymbol for each module that is added to that specific module (@ExperimentalApolloRuntimeApi, ...). I'm too lazy to do it now and also don't want to introduce too much annotation noise so this is left for a future PR.Changes to
@ApolloExperimentalapis will need to be evaluated manually whether they are safe to do (because not used by other modules) or require additional care.