remove unnecessary env sets, make low dep test job to test env vars i…

…n gcp cli executor
apollographql · Sep 26, 2023 · 1f232ec · 1f232ec
1 parent 6684267
commit 1f232ec
Showing 1 changed file with 19 additions and 10 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -140,8 +140,6 @@ jobs:
       - run:
           name: Build
           command: '[ -d build ] || cd packages/explorer && PUBLIC_URL=https://embeddable-explorer.cdn.apollographql.com/_latest npm run build:umd -- --no-progress'
-          environment:
-            BUILD_TO_CDN: 'true'
       - persist_to_workspace:
           root: ~/embeddable-explorer
           paths:
@@ -155,8 +153,6 @@ jobs:
       - run:
           name: Build
           command: '[ -d build ] || cd packages/explorer && PUBLIC_URL=https://embeddable-explorer.cdn.apollographql.com/$CIRCLE_SHA1 npm run build:umd -- --no-progress'
-          environment:
-            BUILD_TO_CDN: 'true'
       - persist_to_workspace:
           root: ~/embeddable-explorer
           paths:
@@ -172,8 +168,6 @@ jobs:
           command: |
             echo $NPM_EXPLORER_VERSION
             [ -d build ] || cd packages/explorer && PUBLIC_URL=https://embeddable-explorer.cdn.apollographql.com/v$NPM_MAJOR_EXPLORER_VERSION npm run build:umd -- --no-progress
-          environment:
-            BUILD_TO_CDN: 'true'
       - attach_workspace:
           at: ~/embeddable-explorer
       - persist_to_workspace:
@@ -234,8 +228,6 @@ jobs:
       - run:
           name: Build
           command: '([ -d build ] || cd packages/sandbox && PUBLIC_URL=https://embeddable-sandbox.cdn.apollographql.com/_latest npm run build:umd -- --no-progress)'
-          environment:
-            BUILD_TO_CDN: 'true'
       - persist_to_workspace:
           root: ~/embeddable-explorer
           paths:
@@ -249,8 +241,6 @@ jobs:
       - run:
           name: Build
           command: '[ -d build ] || cd packages/sandbox && PUBLIC_URL=https://embeddable-sandbox.cdn.apollographql.com/$CIRCLE_SHA1 npm run build:umd -- --no-progress'
-          environment:
-            BUILD_TO_CDN: 'true'
       - persist_to_workspace:
           root: ~/embeddable-explorer
           paths:
@@ -324,6 +314,22 @@ jobs:
             echo $NPM_MAJOR_SANDBOX_VERSION
             gsutil -m rsync -r ~/embeddable-explorer/packages/sandbox/dist gs://embeddable-sandbox/v$NPM_MAJOR_SANDBOX_VERSION
 
+  TEST-cdn-upload-npm-versioned-sandbox:
+    executor: gcp-cli/google
+    steps:
+      - setup-sandbox-gcs-creds
+      - gcp-cli/install
+      - checkout
+      - attach_workspace:
+          at: ~/embeddable-explorer
+      - run: |
+          cat bash.env
+          cat bash.env >> $BASH_ENV
+      - run:
+          name: TEST - just show env var
+          command: |
+            echo $NPM_MAJOR_SANDBOX_VERSION
+
 
 workflows:
   build-test-deploy:
@@ -334,6 +340,9 @@ workflows:
       - set-env-vars
       - build-latest-umd-explorer
       - build-latest-umd-sandbox
+      - TEST-cdn-upload-npm-versioned-sandbox:
+          requires: 
+            - set-env-vars
       - bundlewatch:
           requires:
             - build-latest-umd-explorer