Send payload id if applicable when an exception is caught #545
Conversation
There was a problem hiding this comment.
Hmm. It looks like this could only occur if receive() errored? I'm not clear on when that would happen (though this patch would surely help to figure that out 😄 )
I wonder if we should accept Option<String> on the rust side rather than using a default empty value? Or is that super invasive?
There was a problem hiding this comment.
Ohh wait. I reread it after. My comment about receive() is incorrect.
This patch looks good, we would only get the default empty value if receive() fails, which should not happen ( 😇 ), and we now get the correct value if QP fails, which we previously didn't.
Adjusting my question: is getting an empty value going to be a problem in the router? It shouldn't happen, but it might ;p Either way this is better than before.
Co-authored-by: Renée <[email protected]>
|
This seems working. I don't see this error with this PR. |
If an exception is caught during planning, we previously didn't send the messageId.
The response could thus not be properly routed back to the proper sender, and would lead to such errors as:
This changeset adds the messageId if possible.