This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Fixed unmounted component state update #4021
Open
+14
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project I'm getting the following error with useQuery:
After some debugging, I came into this line:
react-apollo/packages/hooks/src/utils/useBaseQuery.ts
Line 34 in 4bd40a9
Because of the re-render in a microtask this may cause the hook to update the state of an unmounted component. Adding a
isMounted
check fixed the issue.I'm not sure how to add tests for this. Any suggestions?