fix: add backticks around incorrect variable name

"expected $this, got this" is confusing, so hopefully "expected $this, got `this`" helps
apollographql · Oct 17, 2024 · f667229 · f667229
1 parent c850e91
commit f667229
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/apollo-federation/src/sources/connect/url_template.rs b/apollo-federation/src/sources/connect/url_template.rs
@@ -376,7 +376,7 @@ impl FromStr for VariableType {
             .find(|var_type| var_type.as_str() == input)
             .ok_or_else(|| {
                 format!(
-                    "Variable type must be one of {}, got {input}",
+                    "Variable type must be one of {}, got `{input}`",
                     Self::iter().map(|var_type| var_type.as_str()).join(", ")
                 )
             })
@@ -514,7 +514,7 @@ mod test_parse {
         let err = URLTemplate::from_str("/something/{$blah.stuff}/more").unwrap_err();
         assert_eq!(
             err.message,
-            "Variable type must be one of $args, $this, $config, got $blah"
+            "Variable type must be one of $args, $this, $config, got `$blah`"
         );
         assert_eq!(err.location, Some(12..17));
     }

diff --git a/...sources/connect/validation/snapshots/[email protected] b/...sources/connect/validation/snapshots/[email protected]
@@ -6,7 +6,7 @@ input_file: apollo-federation/src/sources/connect/validation/test_data/invalid-p
 [
     Message {
         code: InvalidUrl,
-        message: "`GET` in `@connect(http:)` on `Query.resources` must be a valid URL template. Variable type must be one of $args, $this, $config, got $blah",
+        message: "`GET` in `@connect(http:)` on `Query.resources` must be a valid URL template. Variable type must be one of $args, $this, $config, got `$blah`",
         locations: [
             12:23..12:28,
         ],