Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile dev after merge to main for v1.36.0 #4429

Closed
wants to merge 27 commits into from
Closed

Reconcile dev after merge to main for v1.36.0 #4429

wants to merge 27 commits into from

Conversation

abernix
Copy link
Member

@abernix abernix commented Jan 2, 2024

Follow-up to the v1.36.0 being officially released, bringing version bumps and changelog updates into the dev branch.

garypen and others added 27 commits December 4, 2023 14:42
Add an entry for the health check logging contribution.

---------

Co-authored-by: Jesse Rosenberger <[email protected]>
## Motivation

Updates Changelog that left-out "Coprocessor" impact/aspect of the fix,
which was as applicable as the Rhai aspect (same root cause). I've
already updated the original #4228 PR body to reflect this improved
scope.

## Markdown Preview Below
---

### Rhai scripts or coprocessors no longer prevent traces from appearing
in Apollo Studio ([PR
#4228](#4228))

Previously, trace reports were not appearing in Apollo Studio's
Operations view when the Router was configured with either coprocessors
or Rhai script. That issue has been resolved in this release.

By [@bnjjj](https://github.com/bnjjj) in
#4228
Cherry-picks b3eb495 (merge of
#4316) for updating
telemetry docs

Co-authored-by: Maria Elisabeth Schreiber <[email protected]>
Updated example `@policy` use case, and added tips choosing
`@requiresScopes` vs. `@policy`

Deploy preview:
https://deploy-preview-4361--apollo-router-docs.netlify.app/configuration/authorization
As of 1.30.0, Rhai can now access RouterService

---------

Co-authored-by: Edward Huang <[email protected]>
…mespace (#4372)

Here, it'll actually be handled by our analytics infrastructure.

Follow-up for #4159
the hasher was assuming only inline fragments under _entities queries,
but as an optimization, named fragments can be reused
As an optimization, query fragments can be reused in subgraph _entities
queries, and this case was not handled in some parts of the router

This adds a test for #4387
and #4388 where subgraph
query hashing only supported inline fragments
Fix 4a592f4

If the field we are selecting from is a union, when going into
`execute_selection_set`, `current_type` will be the name of the union.
If we already have a `__typename` field, it will be more precise than
`current_type` and should be used instead
This changeset updates zerocopy to 0.7.31, which has a fix for
https://rustsec.org/advisories/RUSTSEC-2023-0074.
Due to a late-stage bug surfaced from a customer which would have
constitued a regression in release, we had to wait for the introduction of a
fix.  The fix manifested in #4400 and we'll now go for a `-rc.3` again.
apollo_router_http_requests_total is not deprecated
@abernix abernix requested a review from a team as a code owner January 2, 2024 17:18
@router-perf
Copy link

router-perf bot commented Jan 2, 2024

CI performance tests

  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • no-graphos - Basic stress test, no GraphOS.
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • const - Basic stress test that runs with a constant number of users
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode

@abernix
Copy link
Member Author

abernix commented Jan 2, 2024

Re-opening this from another branch so I can do the reconciliation of the merge conflict.

@abernix abernix closed this Jan 2, 2024
@abernix
Copy link
Member Author

abernix commented Jan 2, 2024

Superseded by #4430 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants