-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconcile dev
after merge to main
for v1.44.0
#4947
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The schema aware hash does not take the operation name into account, but the operation name is used in the operation signature, so if the same query is used with 2 different operation names, then they would get the same operation signature, which might disrupt the data in studio
Co-authored-by: Edward Huang <[email protected]>
Still makes Helm sense in the re-write. Co-authored-by: Jeremy Lempereur <[email protected]>
Make clear what is fixed and document the warning messages that have gone away.
garypen
reviewed
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but there's a conflice on license.html
.
Right, I'll merge it manually so main doesnt change when fixing the conflict |
Geal
approved these changes
Apr 12, 2024
Manually merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to the v1.44.0 being officially released, bringing version bumps and changelog updates into the
dev
branch.