-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconcile dev
after merge to main
for v1.48.1
#5395
Conversation
Co-authored-by: Edward Huang <[email protected]> Co-authored-by: Jesse Rosenberger <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
…ponse (#5223) Co-authored-by: Coenen Benjamin <[email protected]> Co-authored-by: Jesse Rosenberger <[email protected]>
Co-authored-by: Renée <[email protected]>
@abernix, please consider creating a changeset entry in |
CI performance tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, why are the commit hashes on this different than the equivalent commits already in dev
? That will add duplicates in the commit history 🤔
I guess it's not an actual problem, but it's a bit fishy. Do we have a rebasing step in the release process or something?
Rubber ducked it. I guess it makes sense because only some commits are added in this release, which means they necessarily have a different parent than the original. |
@goto-bus-stop Fair shout and good observation — we did actually cherry pick more things on this release than usual (we usually have more clean forks from the main trunk) as |
Supersedes my attempt in #5394, follows #5349 and https://github.com/apollographql/router/releases/tag/v1.48.1