Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile dev after merge to main for v1.48.1 #5395

Merged
merged 12 commits into from
Jun 11, 2024
Merged

Conversation

abernix
Copy link
Member

@abernix abernix commented Jun 10, 2024

Copy link
Contributor

@abernix, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Jun 10, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • reload - Reload test over a long period of time at a constant rate of users
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • xlarge-request - Stress test with 10 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • xxlarge-request - Stress test with 100 MB request payload
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • no-graphos - Basic stress test, no GraphOS.
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • large-request - Stress test with a 1 MB request payload
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled

@abernix abernix marked this pull request as ready for review June 10, 2024 18:17
@abernix abernix enabled auto-merge June 10, 2024 18:17
Copy link
Member

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, why are the commit hashes on this different than the equivalent commits already in dev? That will add duplicates in the commit history 🤔

I guess it's not an actual problem, but it's a bit fishy. Do we have a rebasing step in the release process or something?

@goto-bus-stop
Copy link
Member

Rubber ducked it. I guess it makes sense because only some commits are added in this release, which means they necessarily have a different parent than the original.

@abernix abernix merged commit bd6a3d1 into dev Jun 11, 2024
13 of 14 checks passed
@abernix abernix deleted the abernix/main-merge-2024-06 branch June 11, 2024 09:11
@abernix
Copy link
Member Author

abernix commented Jun 11, 2024

@goto-bus-stop Fair shout and good observation — we did actually cherry pick more things on this release than usual (we usually have more clean forks from the main trunk) as dev itself had other more substantial changes that are targeted for 1.49.0 than we wanted for a patch release. Thanks for paying attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants