Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate hyper::Body usage #5478

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

deprecate hyper::Body usage #5478

wants to merge 2 commits into from

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Jun 18, 2024

Follow up to #5175

We cannot just mark the Body type as deprecated, because it is just an alias to an external type. Instead, we can add the deprecation notice on the router request and response types. We can also allow deprecated elements inside the router code, to avoid warnings internally


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

Copy link
Contributor

@Geal, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Jun 18, 2024

CI performance tests

  • reload - Reload test over a long period of time at a constant rate of users
  • no-tracing - Basic stress test, no tracing
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • xlarge-request - Stress test with 10 MB request payload
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • step - Basic stress test that steps up the number of users over time
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • large-request - Stress test with a 1 MB request payload
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • const - Basic stress test that runs with a constant number of users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant