Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile dev after merge to main for v1.49.1 #5487

Merged
merged 7 commits into from
Jun 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 33 additions & 6 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,38 @@ All notable changes to Router will be documented in this file.

This project adheres to [Semantic Versioning v2.0.0](https://semver.org/spec/v2.0.0.html).

# [1.49.1] - 2024-06-19

> [!IMPORTANT]
> If you have enabled [Distributed query plan caching](https://www.apollographql.com/docs/router/configuration/distributed-caching/#distributed-query-plan-caching), this release changes the hashing algorithm used for the cache keys. On account of this, you should anticipate additional cache regeneration cost when updating between these versions while the new hashing algorithm comes into service.

## 🔒 Security

### Replace dependency included in security advisory ([Issue #5484](https://github.com/apollographql/router/issues/5484))

This removes our use of a dependency that was cited in security advisories [RUSTSEC-2024-0344](https://rustsec.org/advisories/RUSTSEC-2024-0344) and [GHSA-x4gp-pqpj-f43q](https://github.com/advisories/GHSA-x4gp-pqpj-f43q).

We have carefully analyzed our usages and determined that **Apollo Router is not impacted**. We only relied on different functions from the same dependency that were easily replaced. Despite lack of impact, we have opted to remove the dependency entirely out of an abundance of caution. This not only clears the warning on our side immediately, but also provides a clear path forward in the event that this shows up in any of our user's own scans.

Users may upgrade at their own discretion, though as it was determined there is no impact, upgrading is not being explicitly recommended.

See [the corresponding GitHub issue](https://github.com/apollographql/router/issues/5484).

By [@Geal](https://github.com/Geal) in https://github.com/apollographql/router/pull/5483

## 🐛 Fixes

### Update to Federation v2.8.1 ([PR #5483](https://github.com/apollographql/router/pull/5483))

The above security fix was in `router-bridge` which had already received a Federation version bump. This bump takes Federation to v2.8.1, which fixes a performance-related matter in *composition*. However, it does **not** impact query planning, which means this particular update is a no-op and this is simply a symbolic bump of the number itself, rather than any functional change.

By [@Geal](https://github.com/Geal) in https://github.com/apollographql/router/pull/5483

# [1.49.0] - 2024-06-18

> [!IMPORTANT]
> If you have enabled [Distributed query plan caching](https://www.apollographql.com/docs/router/configuration/distributed-caching/#distributed-query-plan-caching), this release changes the hashing algorithm used for the cache keys. On account of this, you should anticipate additional cache regeneration cost when updating between these versions while the new hashing algorithm comes into service.

## 🚀 Features

### Override tracing span names using custom span selectors ([Issue #5261](https://github.com/apollographql/router/issues/5261))
Expand All @@ -20,7 +50,7 @@ telemetry:
spans:
router:
otel.name:
static: router # Override the span name to router
static: router # Override the span name to router
```

By [@bnjjj](https://github.com/bnjjj) in https://github.com/apollographql/router/pull/5365
Expand All @@ -41,7 +71,7 @@ By [@garypen](https://github.com/garypen) in https://github.com/apollographql/ro

### Add support for `unix_ms_now` in Rhai customizations ([Issue #5182](https://github.com/apollographql/router/issues/5182))

Rhai customizations can now use the `unix_ms_now()` function to obtain the current Unix timestamp in milliseconds since the Unix epoch.
Rhai customizations can now use the `unix_ms_now()` function to obtain the current Unix timestamp in milliseconds since the Unix epoch.

For example:

Expand Down Expand Up @@ -80,9 +110,6 @@ By [@BrynCooke](https://github.com/BrynCooke) in https://github.com/apollographq

This fixes performance issues when looking up query plans for large schemas.

> [!IMPORTANT]
> If you have enabled [Distributed query plan caching](https://www.apollographql.com/docs/router/configuration/distributed-caching/#distributed-query-plan-caching), this release changes the hashing algorithm used for the cache keys. On account of this, you should anticipate additional cache regeneration cost when updating between these versions while the new hashing algorithm comes into service.

By [@Geal](https://github.com/Geal) in https://github.com/apollographql/router/pull/5374

### Optimize GraphQL instruments ([PR #5375](https://github.com/apollographql/router/pull/5375))
Expand Down Expand Up @@ -206,7 +233,7 @@ In the short-term, benefits include:
- Additional spans that were previously not included in Studio traces, such as query parsing, planning, execution, and more.
- Additional metadata such as subgraph fetch details, router idle / busy timing, and more.

Long-term, we see this as a strategic enhancement to consolidate these two disparate tracing systems.
Long-term, we see this as a strategic enhancement to consolidate these two disparate tracing systems.
This will pave the way for future enhancements to more easily plug into the Studio trace visualizer.

#### Configuration
Expand Down
Loading
Loading