Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields referenced only in entity arguments to split subgraphs #6203

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

dylan-apollo
Copy link
Member

@dylan-apollo dylan-apollo commented Oct 28, 2024

Technically also allows some interface stuff that won't work, but it's caught in validation! Based on #6201 which should be merged first.

@dylan-apollo dylan-apollo requested review from nicholascioli and a team as code owners October 28, 2024 22:05
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Oct 28, 2024

✅ Docs Preview Ready

No new or changed pages found.

@router-perf
Copy link

router-perf bot commented Oct 28, 2024

CI performance tests

  • connectors-const - Connectors stress test that runs with a constant number of users
  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

Base automatically changed from dylan/regenerate-expansion-tests to next October 29, 2024 15:06
Copy link
Contributor

@lennyburdette lennyburdette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@dylan-apollo dylan-apollo force-pushed the dylan/include-key-fields-from-inputs-in-expansion branch from ed099fd to 7ed3101 Compare October 29, 2024 16:23
@dylan-apollo dylan-apollo enabled auto-merge (squash) October 29, 2024 16:24
@dylan-apollo dylan-apollo merged commit 1eafe2f into next Oct 29, 2024
11 of 13 checks passed
@dylan-apollo dylan-apollo deleted the dylan/include-key-fields-from-inputs-in-expansion branch October 29, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants